Block API: Allow overriding the category for block variations #28482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
requested review from
ajitbohra,
chrisvanpatten,
ellatrix and
mkaz
as code owners
gziolo
added
[Status] In Progress
gziolo
commented
Jan 26, 2021
| @@ -71,19 +71,6 @@ export const searchBlockItems = ( | |||
| find( categories, { slug: item.category } )?.title, | |||
| getCollection: ( item ) => | |||
| collections[ item.name.split( '/' )[ 0 ] ]?.title, | |||
| getVariations: ( { variations = [] } ) => | |||
There was a problem hiding this comment.
No longer referenced in the code as of #25182.
gziolo
added
[Type] New API
|
Size Change: -57 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Jan 26, 2021
|
@gziolo Sorry for the delayed response on this. Appreciate you pushing this through! |
lipemat
added a commit
to lipemat/types-js-boilerplate
that referenced
this pull request
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Raised #16283 (comment) in by @badfeather:
This PR was opened to add a
categoryfield to the Block Variations API. It looks like block variations are now discovered with a selector as of #25182 from @youknowriad. So the rest of the changes was straightforward.How has this been tested?
I modified the category in the variations defined for the Navigation block to test.
Screenshots
Types of changes
Checklist: