Load page templates via theme.json abstractions #28700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
spacedmonkey and
TimothyBJacobs
as code owners
6 tasks
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
oandregal
force-pushed
the
update/page-templates-theme-json
branch
from
11f4d79 to
247efa2
Compare
oandregal
added
Global Styles
Addison-Stavlo
approved these changes
Feb 4, 2021
Thank you 🙂 |
oandregal
force-pushed
the
update/page-templates-theme-json
branch
from
6ed01a9 to
469cb6c
Compare
This was referenced Feb 5, 2021
Comment on lines
+21
to
+22
| $resolver = new WP_Theme_JSON_Resolver(); | ||
| $data = $resolver->get_theme_data()->get_page_templates(); |
There was a problem hiding this comment.
Circling back to this. Now that theme is static. Do we need to call new here? Or would something like:
WP_Theme_JSON_Resolver::get_theme_data()->get_page_templates(); work?
There was a problem hiding this comment.
Here's the follow-up that bundles non-behavioral changes: #28855 (it also makes get_theme_data static).
This was referenced Feb 9, 2021
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #27778 (which introduced the
pageTemplatesfield in theme.json) and #28110 #28533 that refactored it to accommodate the new needs for this file #28163The idea is to mature the APIs we use to read data from theme.json, as to:
An initial list of steps we need to check when adding new fields to
theme.json:While the role of the
WP_Theme_JSONclass in this space seems well established, the role ofWP_Theme_JSON_Resolverneeds to be accommodated to the new use cases we want to support beyond settings & styles. This PR is the first step to do that and usespageTemplatesas an example.Proposed API for consumers:
How to test
masterbranch). It defines one page template: page-home whose text is "Page without title".experimental-theme.jsonof the TT1-blocks theme and update the text to be "My home page".Follow-ups
This PR refactors code, it doesn't change any behavior. A follow up to this that adds new behavior is a PR that enables the page template title to be translated.
I think
WP_Theme_JSON_Resolverneeds more maturation. I'd like to create small and focused follow-up PRs to improve it. It'll allow us to move quickly by making reviews easier.