i18n hooks: don't use typeof to check value falsiness #28733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -11 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small spinoff from #28465, removing
typeofusages that just check a variable value.The advantage of
typeof x === 'undefined'over just! xorx === 'undefined'is thattypeofdoesn't fail whenxis not defined at all. That makes it convenient for checks liketypeof windowortypeof document. But for checking variables we know to exist, more classic conditions are OK.Review request for @leewillis77