Update Appium dependency version to 1.20.2 #28890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
|
Looks like one of the dependencies required by Appium has an incompatible license: I'm not sure what's the solution for this, what's done in this cases? |
This was referenced Feb 9, 2021
Confirmation for adding |
|
Reading this comment in our gutenberg/packages/scripts/scripts/check-licenses.js Lines 67 to 79 in 1a29dbd we might actually with the cc/ @gziolo |
|
@ockham, yes, I made the same assumption but I didn't get any clear answer on the WordPress Slack. I would personally add another exception for Python 2.0 unless someone confirms it's no go. |
|
I had a closer look at the Here's the nitty gritty: Unlike the
That part is found in the "CNRI OPEN SOURCE LICENSE AGREEMENT (for Python 1.6b1)" section. (I'm not even sure if that part is legally binding or just there for historic purposes.) Anyway, I think that that part is what is mentioned by the GNU project's license list as the reason for that license being GPL-incompatible:
Anyway,
Note that this is identical to what the GNU Project calls the Python-2.0.1 license (which unfortunately isn't an SPDX-listed license), and lists as GPL-compatible 🎉 |
|
The way forward (based on #28890 (comment)). In an ideal world: SPDX would include
More practically, to unblock us: We can include the As a follow-up: Maybe using an existing (3rd party) license checker tool could alleviate some maintenance burden. See e.g. |
|
I've just merged #28968, going to rebase this PR now. |
ockham
force-pushed
the
update/appium-1.20.2-npm-6
branch
from
59a6a34
to
ca847be
Compare
|
Thank you very much @ockham and @gziolo for the help and the awesome work on this 🎊 !
Yeah, I've already requested review on the |
2 tasks
7 tasks
|
Tested and approved via wordpress-mobile/gutenberg-mobile#3121 (review). |
This was referenced Feb 15, 2021
spdx/license-list-XML#1200 and nodeca/argparse#160 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3121Description
Appium dependency has recently included a fix for preventing an error when using NPM version 7 so it would be nice to update it.
How has this been tested?
Appium is used for running the end-to-end tests on the mobile version of the editor so for verifying that this is working it will require to run them.
It will be tested in the
guteberg-mobilePR: wordpress-mobile/gutenberg-mobile#3121, so this PR shouldn't be merged until that PR is approved.Screenshots
N/A
Types of changes
Bug fix
Checklist: