Site Editor: Fix e2e test errors introduced by template sidebar #28950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
david-szabo97
requested review from
ajitbohra,
nerrad and
ntwb
as code owners
david-szabo97
changed the title
david-szabo97
requested review from
youknowriad,
vindl,
jeyip,
mattwiebe,
Addison-Stavlo and
Copons
david-szabo97
added
the
[Type] Automated Testing
vindl
approved these changes
Feb 11, 2021
|
Nice! Thanks! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like some changes were made in this PR #28835 that removed the custom component based toolbar control. The #28633 PR we just merged still included that check, which is now causing the e2e tests to fail on new PRs.
How has this been tested?
CI tests should pass
Types of changes
Automated testing
Checklist: