Refine ESLint configuration #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
Framework
aduth
force-pushed
the
update/refine-eslint-config
branch
from
f8e97c5 to
7d904ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifies Node environment to avoid errors on keywords such as
require,process. Notably inwebpack.config.js. While these will likely not be common in client code, they're supported by Webpack nonetheless.Disables
one-varESLint rule. I'd argue this is a complementary ofvars-on-topwhich is not relevant in an ES2015+ environment.Adds configuration for Travis CI. This is not yet enabled and we'll need to resolve a few of the outstanding errors (from stubbed functions). Travis was chosen for best consistency with core integration (source).