-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts: Allow CSS modules in the build commands #29182
Conversation
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @cpiber! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
Hi @cpiber. Thank you for your contribution. Can you provide more details for the proposed change?
|
|
That would be a great addition with an example of the file and its content maybe? There is already a section with CSS: I guess once we have documentation. It only needs to be tested and we are good to go. Thank you for your contribution 🙇🏻 |
To clarify, do you want me to edit the README? |
Yes, that would be helpful for folks using A section https://github.com/WordPress/gutenberg/blob/trunk/packages/scripts/CHANGELOG.md |
It looks like you merged your branch with the upstream |
I rebased on |
I'm not sure what went wrong but there should be only your changes listed in this PR. You can try following this documentation and see if it helps: |
I used |
You can also cherry-pick your commits to a fresh branch if that helps. Whatever makes it work and I can merge your changes 😄 |
Alright, I went back to the old master and did a merge instead of a rebase, I hope it's okay now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. This looks good to go 🎉
Congratulations on your first merged pull request, @cpiber! We'd like to credit you for your contribution in the post announcing the next WordPress release, but we can't find a WordPress.org profile associated with your GitHub account. When you have a moment, visit the following URL and click "link your GitHub account" under "GitHub Username" to link your accounts: https://profiles.wordpress.org/me/profile/edit/ And if you don't have a WordPress.org account, you can create one on this page: https://login.wordpress.org/register Kudos! |
Description
@wordpress/scripts modified config to allow css modules (and extract them like style.css)
Checklist: