Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix specificity issue between theme and user styles #29533

Merged
merged 4 commits into from
Mar 4, 2021
Merged

Fix specificity issue between theme and user styles #29533

merged 4 commits into from
Mar 4, 2021

Commits on Mar 4, 2021

  1. Add test cases

    @oandregal
    oandregal committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    fc91941 View commit details
    Browse the repository at this point in the history

  2. Make preset values !important 

    Given how the style system works, !important is a good choice
for preset classes the user attaches to the post content.
If those values need to be overridden, in addition to regular CSS,
we can offer hooks for the theme.json processing,
so plugins have an alternate mechanism to modify this behavior.
    @oandregal
    oandregal committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    980a0b6 View commit details
    Browse the repository at this point in the history

  3. Rename test

    @oandregal
    oandregal committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    c1b48bd View commit details
    Browse the repository at this point in the history

  4. Make linter happy

    @oandregal
    oandregal committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    1649841 View commit details
    Browse the repository at this point in the history