Try: One appender at a time. #29559
Closed
Try: One appender at a time. #29559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +34 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
|
I've changed my mind on this one. Feel free to give feedback on the GIF and behavior, but going to close this one for now. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Nesting groups have block appenders.
Nesting groups inside nesting groups also have block appenders, and all levels of appenders are always shown.
This PR changes it so that only the selected nesting group shows appenders.
Before:
Note how the appender for the navigation container, and the social links container, both show appenders.
Note how the group container shows a nesting container, even when the child block is selected.
After:
Note how when the Social Links container is selected, only its appender is shown, not that of its parent.
Note how the group appender is shown only when the group is selected.
How has this been tested?
Insert a group with an image, observe the behavior described above.
Insert a navigation block with social links inside. Observe the behavior described above.
Types of changes
I'm not sure about this PR. I think it's an obvious benefit for nested nesting containers — groups inside groups inside groups, or the navigation with social links as shown.
But in the simpler example of the group with an image inside might not be what we want. An alternative is to scope these changes only to individual blocks, like the navigation block.
Checklist: