-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create block: Require WordPress 5.7 by default and source it from the main plugin file #29757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
changed the title
Create block: Require WordPress 5.7 by default
Create block: Require WordPress 5.7 by default and source it from the main plugin file
Mar 11, 2021
gziolo
added
[Tool] Create Block
/packages/create-block
[Type] Enhancement
A suggestion for improvement.
labels
Mar 11, 2021
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/create-block-wordpress-5.7
branch
2 times, most recently
from
March 11, 2021 10:12
cca9265
to
2560d60
Compare
gziolo
force-pushed
the
update/create-block-wordpress-5.7
branch
from
March 11, 2021 10:24
2560d60
to
e772e93
Compare
fabiankaegy
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #29646.
Now that the new major version of WordPress (5.7) is out, we can set it as the default required version of the plugin to use the latest Block API. It means we no longer need to set
apiVersion
in JavaScript when usingblock.json
for block registraton on the server.This PR also moves the setting for minimum WP and PHP version to the main plugin file as explained in #29646 (comment):
How has this been tested?
npx wp-create-block -t es5
should work as before.Screenshots
You should see such message when you use older version of WordPress than required.
Types of changes
Enhancement related to the WordPress major version release.
Checklist: