Fix sibling block inserter displaying at end of block list. #29920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
commented
Mar 17, 2021
packages/block-editor/src/components/block-list/insertion-point.js
Outdated
Show resolved
Hide resolved
|
Size Change: +10 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
talldan
force-pushed
the
fix/double-inserter
branch
from
2ee5abd
to
da8b765
Compare
talldan
force-pushed
the
fix/double-inserter
branch
from
da8b765
to
1955412
Compare
|
I'm not completely sure why this suddenly caused a consistent test failure, but the test was selecting a template part by clicking, and was failing because it clicked the inserter between two columns in the template part. Testing manually, the same thing happens in It's actually pretty difficult to select the template part by clicking the block itself, so I've updated the test to use List View to select the block. Edit: same issue with the document settings test as well. |
ellatrix
reviewed
Mar 19, 2021
| @@ -200,6 +200,18 @@ function InsertionPointPopover( { | |||
| } | |||
| } | |||
|
|
|||
| // Only show the inserter when there's a `nextElement` (a block after the | |||
| // insertion point). At the end of the block list the trailing appender | |||
| // should serve the purpose of inserting blocks. | |||
There was a problem hiding this comment.
What if there's no appender available?
There was a problem hiding this comment.
I don't think that's an issue, from what I understand this inserter was never intended to show at the end of a block list. Its appearance there is a bug from #28418.
ellatrix
approved these changes
Mar 19, 2021
|
Thanks for reviewing @ellatrix. |
|
Thanks for fixing this :) I appreciate it. |
youknowriad
added
the
Backport to WP Minor Release
noisysocks
pushed a commit
that referenced
this pull request
Apr 6, 2021
* Only show inserter version of insertion point if there is a next block * Clarify comment * Improve boolean logic * Update e2e test * Update tests
noisysocks
removed
the
Backport to WP Minor Release
noisysocks
pushed a commit
that referenced
this pull request
Apr 6, 2021
* Only show inserter version of insertion point if there is a next block * Clarify comment * Improve boolean logic * Update e2e test * Update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #28907
How has this been tested?
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: