Fix error in site-editor when presets are null #30144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +17 B (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Mar 23, 2021
| `--wp--preset--${ cssVarInfix }--${ value.slug }: ${ value[ valueKey ] }` | ||
| ); | ||
| } ); | ||
| if ( preset ) { |
There was a problem hiding this comment.
That's interesting. It looks like get doesn't add enough safety because preset is defined but set to some falsy value.
|
Can we check why the preset doesn't have an array value? I don't understand why that happens: if the theme doesn't provide a preset the algorithm uses the core's defaults https://github.com/WordPress/gutenberg/blob/trunk/lib/experimental-default-theme.json#L4 I wonder if there's a bigger issue, something we landed that have broken this. |
2 tasks
|
@nosolosw it started happening today for themes that are missing |
My point is that to avoid having those checks all over the codebase in every place that data is accessed, we centralize the sanitization logic in the constructor of WP_Theme_JSON, so the other methods know the data is safe to process and don't need to do this check again. |
9 tasks
7 tasks
|
#30171 might fix it but we need better test coverage for |
|
I'll go ahead and close this one since #30171 fixes the issue correctly 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In an FSE theme if some things are missing from theme.json, the site-editor crashes with an error
TypeError: can't access property "forEach", preset is null. After fixing that there's a 2nd error forpresets. This PR fixes these 2 so the site-editor can continue loading if the theme doesn't have everything under the sun.To replicate the issue remove the gradients from TT1-blocks' theme.json.
How has this been tested?
Tested with an FSE theme that is missing gradients definitions in theme.json
Types of changes
Added a check to only run the loops if
preset&presetsare not null.Checklist: