Plugin: Ensure that plugin does not error with older versions of WordPress #30230
+180
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Bug
gziolo
force-pushed
the
update/gutenberg-plugin-init
branch
from
138d5c5
to
36c11ef
Compare
4 tasks
gziolo
changed the title
|
Size Change: 0 B Total Size: 1.41 MB ℹ️ View Unchanged
|
|
Previously reported in #27998. You might want to link the PR to that ticket. |
|
@swissspidy, thanks. I added in the description. It will fully fix the issue with the other PR combined. |
|
Thanks @gziolo - I think this approach is great and helps the main plugin file communicate much more clearly. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially addresses #27998.
Improvements towards resolving the issue raised in #29938 by @jeremyfelt:
This PR moves the logic that causes issues to their own file that is conditionally loaded through the
lib/load.phpentry point.How has this been tested?
Plugin should load as usual.
Types of changes
Refactoring.
Checklist: