Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: Skip flaky e2e tests #30344

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Testing: Skip flaky e2e tests #30344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/e2e-tests/specs/editor/various/multi-block-selection.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,8 @@ describe( 'Multi-block selection', () => {
expect( await getSelectedFlatIndices() ).toBe( 3 );
} );

it( 'should deselect with Escape', async () => {
// Flaky test.
it.skip( 'should deselect with Escape', async () => {
await clickBlockAppender();
await page.keyboard.type( '1' );
await page.keyboard.press( 'Enter' );
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-editor/jest_ui_test_environment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class CustomEnvironment extends JSDOMEnvironment {
}

async teardown() {
await this.global.editorPage.stopDriver();
await this.global.editorPage?.stopDriver();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is a good fix, mainly a hunch to see if it fixes the instability.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stopDriver being undefined is usually the result of a failure with something else. But I understand that it causes confusion to see this error. I think it should be fine to have this change.

await super.teardown();
}
}
Expand Down