Block Library: Revert column-gap property for spacing between custom-sized buttons #30449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
added
[Type] Regression
|
Size Change: -238 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
gziolo
changed the title
|
Looks like with Safari 14.1 this can be used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the changes from #29165, commit 069aa44.
In testing, we overlooked an issue where Safari's partial support of the
gap/column-gapproperty provides an inaccurate response to the@supportsquery. Safari will say that it supports those properties, but in reality it only supports them forgrid, not forflexbox. We need to use them with flexbox here. 😞I tried some workarounds, but I couldn't find something that worked. In the meantime, I think it's best to just revert this to stop the regression in button spacing for Safari. We can try another approach later.
More reading on the topic:
w3c/csswg-drafts#3559
https://ishadeed.com/article/flexbox-gap/
Screenshots (in Safari)