dom: Add types to miscellaneous files #30774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Type] Code Quality
|
Size Change: +6 B (0%) Total Size: 1.46 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Apr 13, 2021
sarayourfriend
force-pushed
the
add/dom-types-misc
branch
from
99e5875 to
1967407
Compare
5 tasks
tyxla
approved these changes
Apr 14, 2021
| * | ||
| * @return {?Element} Scrollable container node, if found. | ||
| * @return {undefined | Element} Scrollable container node, if found. |
There was a problem hiding this comment.
Nit: I generally prefer X | undefined instead of undefined | X. Or is there a reason to prefer the latter?
sarayourfriend
force-pushed
the
add/dom-types-misc
branch
from
1967407 to
348f5cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds types to miscellaneous
domfiles.Part of #18838
How has this been tested?
Minimal to zero runtime checks (just null checks), e2e tests pass, unit tests pass, type checks pass
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).