Revert: Site logo width. #30843
Closed
Revert: Site logo width. #30843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Regression
jasmussen
force-pushed
the
revert/site-logo-width
branch
from
b39a94a to
ff15b37
Compare
|
Size Change: -133 B (0%) Total Size: 1.46 MB
ℹ️ View Unchanged
|
shaunandrews
approved these changes
Apr 14, 2021
7 tasks
|
I just created an alternative in #30845 which fixes the issue letting us keep the CSS. Thanks for the review — if this needs to land in a point release, it's good to have a choice between the "safe" solution (revert), and a fix, which might feel less dafe. |
|
Closing this one in favor of #30846. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts parts of #30526 as that failed to take in account published site logos that were not resized.
Creating this revert as an interim solution as I look for a better way to do the default width.
Checklist:
*.native.jsfiles for terms that need renaming or removal).