Block editor: scroll selected block only if it has no focus #30924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
ellatrix
commented
Apr 16, 2021
| @@ -102,6 +103,8 @@ export function useBlockProps( props = {}, { __unstableIsHtml } = {} ) { | |||
| const mergedRefs = useMergeRefs( [ | |||
| props.ref, | |||
| useFocusFirstElement( clientId ), | |||
| // Must happen after focus because we check for focus in the block. | |||
| useScrollIntoView( clientId ), | |||
There was a problem hiding this comment.
Ideally we have a hook that does combines this: if a selected block has no focus, either focus the first element (if so desired) or scroll the block into view.
There was a problem hiding this comment.
(If we do set focus, the browser will automatically scroll it into view if needed.)
|
Size Change: -3 B (0%) Total Size: 1.46 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Apr 19, 2021
|
Awesome, thanks for the improvement :) |
mtias
added
the
[Feature] Writing Flow
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduced by #28191.
Fixes #20764.
Currently, when you select any block that is even slightly out of view, the page will be automatically scroll the block so that the top of the block is visible.
This can be very disorientating especially when dealing with large blocks.
For example: clicking at the bottom of a large cover block would scroll the top into view and the bottom out of view.
Generally, we should not be scrolling the page at all when a block is selected by the user.
This PR only allows scrolling only if the focus is not within the block (and thus not selected by the user directly).
I moved this behaviour to the block component so that we no longer need
getBlockDOMNode.How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).