E2E Site Editor Test: Evaluate getEditedPostContent on the page #31121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.47 MB ℹ️ View Unchanged
|
david-szabo97
requested review from
vindl,
jeyip,
mattwiebe,
Copons,
Addison-Stavlo,
creativecoder and
ntsekouras
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
page.evaluatereturns undefined if we are trying to return something that contains unserializable value(s). This might be a function, DOM reference, or something similar.An
editedentity may contain acontentproperty asfunction. Since this is unserializable,await page.evaluate()returnsundefined.As a fix, we move the logic to the page so we only get back a
stringwhich is always serializable.How has this been tested?
Make sure tests are passing.
Checkout to #30804
Apply this PR
Make sure tests are not failing with
getEditedPostContentreturning undefined. (getAllBlockswill still returnundefined)Screenshots
Types of changes
Improve E2E tests consistency
Checklist:
*.native.jsfiles for terms that need renaming or removal).