Add additional text formatting options to the site title block #31734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Enhancement
|
Size Change: +2.8 kB (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Depending on what is decided for the post title block, I do not believe it is a good idea to expose the underline control to users. |
added 2 commits
May 13, 2021 10:35
…tor" This reverts commit bc8e22e.
Based on #31623 (comment) I tend to agree that underline is not helpful for this block, and I also think there is no need for strikethrough in terms of the site title, so have simplified the PR for now to just add the Appearance typography options. |
This was referenced May 12, 2021
aaronrobertshaw
approved these changes
May 13, 2021
13 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partly fixes #27830 There is currently no way to add inline html to the site title block due to the fact that the site title can only be saved as a plan string, and is used in multiple places, eg. browser tab titles.
Adding additional text formatting block supports at least gives additional control of the formatting of the complete string.
To Test
Site titleblockScreenshots
Before:
After:
