Components: Remove unused focus prop from Button #3201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
[Feature] UI Components
Codecov Report
@@ Coverage Diff @@
## master #3201 +/- ##
=========================================
- Coverage 31.56% 31.5% -0.07%
=========================================
Files 221 221
Lines 6311 6304 -7
Branches 1121 1120 -1
=========================================
- Hits 1992 1986 -6
+ Misses 3631 3630 -1
Partials 688 688
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #896, #1459
This pull request seeks to remove the
focusprop from theButtoncomponent, originally introduced in #896 and later its only usage removed in #1459. This helps simplify the component, which no longer requires lifecycle or a boundref.Testing instructions:
Verify there are no regressions in button behavior.