List Block: Add typography styles to theme.json #32273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Block] List
aristath
reviewed
May 27, 2021
aristath
reviewed
May 27, 2021
Co-authored-by: Ari Stathopoulos <aristath@gmail.com>
Co-authored-by: Ari Stathopoulos <aristath@gmail.com>
|
Size Change: +6 B (0%) Total Size: 1.86 MB
ℹ️ View Unchanged
|
|
👋 I've prepared an alternative to this, see #32343 The issue here is that the |
|
I am torn. I feel strongly that the class should be used both on the front and in the editor, as part of making the front and editor match. At the same time #32343 is a simpler fix. |
|
I'd think we could close this one now, as it's fixed by #32343 A concern I'd have to land this PR is that it is not backward compatible, as it does not work with existing content. |
|
Closing in favour of #32343 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following on from #27510 (comment), this makes it possible to style list blocks via theme.json. This will only work for new blocks that are created, not for previously created ones.
How has this been tested?
Screenshots
Types of changes
New feature (non-breaking change which adds functionality)
Checklist:
*.native.jsfiles for terms that need renaming or removal).