Fix bug with pasting into rich text blocks #32527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Bug
|
Size Change: +2 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Jun 9, 2021
aaronrobertshaw
approved these changes
Jun 9, 2021
There was a problem hiding this comment.
LGTM 👍
I could replicate the issue both via deleting paragraph contents prior to pasting and psating the same content twice in succession.
After applying this patch, it works as expected and I no longer receive errors in console.
The failing e2e test looks unrelated and might just need to be re-run.
|
@ellatrix I did have a bit of a look to try and work out why |
|
@ellatrix I did some more debugging on this and according to a quick git bisect it looks like the issue was introduced in https://github.com/WordPress/gutenberg/pull/31752/files - I have run out of time to work out how exactly, but will take a closer tomorrow if you don't have time to look at it. |
|
Thanks! Yeah tracking down why it isn't defined would be best. Otherwise we can do this for now if it's an important bug to fix for the WP release. |
|
got stuck on a production issue today so didn't make any progress on this. |
|
@ellatrix It seems that the issue is that previously Passing |
ellatrix
approved these changes
Jun 21, 2021
talldan
added
the
Backport to WP 6.7 Beta/RC
|
It'd be good to backport this to edit: I mean WordPress 5.8! |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
|
Cherry-picked into release/10.9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional chaining to prevent exception if activeFormats not defined.
Fixes #32526
Description
Currently when pasting into a rich text block like paragraph multiple times an exception is thrown and the text does not appear in the editor
Testing
Screenshots
Before:
After:
