Card: update to g2 implementation #32566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Package] Components
|
Size Change: +252 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
11 tasks
ciampo
force-pushed
the
feat/components-card-types
branch
2 times, most recently
from
dc6ad74
to
6bce1b3
Compare
ciampo
force-pushed
the
feat/components-card-promote
branch
from
99bfd97
to
39d742c
Compare
ciampo
commented
Jun 10, 2021
ciampo
commented
Jun 10, 2021
| @@ -71,11 +81,17 @@ type MarginalSubComponentProps = BaseSubComponentProps & { | |||
| * @default false | |||
| */ | |||
| isBorderless?: boolean; | |||
| className?: string; | |||
There was a problem hiding this comment.
This is not necessary anymore since the CardHeader and CardFooter components are using PolymorphicComponentProps
ciampo
force-pushed
the
feat/components-card-promote
branch
from
39d742c
to
43f4c68
Compare
ciampo
requested review from
sarayourfriend,
youknowriad,
tyxla,
diegohaz and
gziolo
ciampo
commented
Jun 10, 2021
ciampo
commented
Jun 10, 2021
Comment on lines
-109
to
-145
| export function bodySize() { | ||
| return ` | ||
| &.is-size { | ||
| &-large { | ||
| padding: ${ space( 3 ) } ${ space( 4 ) }; | ||
| } | ||
| &-medium { | ||
| padding: ${ space( 2 ) } ${ space( 3 ) }; | ||
| } | ||
| &-small { | ||
| padding: ${ space( 2 ) }; | ||
| } | ||
| &-extraSmall { | ||
| padding: ${ space( 1 ) }; | ||
| } | ||
| } | ||
| `; | ||
| } | ||
|
|
||
| export function headerFooterSizes() { | ||
| return ` | ||
| &.is-size { | ||
| &-large { | ||
| padding: ${ space( 3 ) } ${ space( 4 ) }; | ||
| } | ||
| &-medium { | ||
| padding: ${ space( 2 ) } ${ space( 3 ) }; | ||
| } | ||
| &-small { | ||
| padding: ${ space( 2 ) }; | ||
| } | ||
| &-extraSmall { | ||
| padding: ${ space( 1 ) }; | ||
| } | ||
| } | ||
| `; | ||
| } |
ciampo
force-pushed
the
feat/components-card-promote
branch
from
43f4c68
to
76e24af
Compare
ciampo
commented
Jun 14, 2021
| export function useCard( props ) { | ||
| const { | ||
| className, | ||
| elevation = 0, |
There was a problem hiding this comment.
Compared to the g2's "original" implementation, I changed the default value of the elevation prop to 0. This is to match the default value of false that the isElevated prop has in the old (production) card implementation
|
This is looking great so far! I'm glad you decided to split this PR into multiple phases, it makes it much easier to review. |
ciampo
force-pushed
the
feat/components-card-promote
branch
from
5312d7e
to
4fe415f
Compare
|
Am I correct in my quick search that there are no usages of the Is the only way to test this component through the storybook for now? I seriously cannot find any usages in Gutenberg. |
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
…ues for the `size` prop
…mputing deprecatedProps
ciampo
force-pushed
the
feat/components-card-promote
branch
from
6c2cbd9
to
5bd2875
Compare
|
Did one last rebase to include #32745, which fixes the context bugs mentioned above. I'll do some final manual checking, wait for tests to pass and merge |
ciampo
removed
the
[Status] Blocked
5 tasks
|
Why was Can we either switch back to |
6 tasks
Hey @TimothyBJacobs , thank you for reporting this. I've opened #37097 to re-introduce support for the |
This was referenced Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is part of a series of PRs with the final goal of achieving the same result as #32243 in smaller (and easier to review) steps.
Requires #32557 and #32561 to be merged first.
<Card />set of components with the new g2 implementation (found inpackages/components/src/ui/card, which is based on a new context system and Emotion'scssfunction for the styles.isElevatedprop on the<Card />component is being soft-deprecated in favour of a newelevationprop (which enables fine-grain control on the card's elevation)<CardMedia />component didn't originally have a g2 implementation and was created directly in this PR (pretty much a 1:1 with the current version)<CardDivider />component didn't originally have a g2 implementation and was created directly in this PR. Although its APIs are the same as the old version, internally it now extends the<Divider />componentpaddingassociated with thesizeproperty has been tweaked to match the same spacing as in the old version of the componentsTesting instructions
CardStorybookCardStorybook:npm run storybook:devhttp://localhost:50240/?path=/story/components-card--defaultComponents / Card / Media - Horizontally Aligned<Card />in the repo keep working as beforeScreenshots
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).