[RNMobile] Improve unsupported block message for reusable block #32618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unsupported block message has been updated and the convert to regular blocks button has been also included.
fluiddot
added
[Type] Enhancement
|
@iamthomasbishop I'd appreciate your input on this change, let me know if you have any suggestions, thanks 🙇 ! |
|
Size Change: +2.57 kB (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
|
@fluiddot Looks pretty good. I think we could make the "alternatively" part a bit clearer, maybe something along the lines of:
What do you think? |
Sure! I'll update that part with your suggestion, thanks! |
|
I updated the screenshots and video capture of the PR description with the last changes mentioned in this comment. @iamthomasbishop I finally changed the message to |
2 tasks
fluiddot
added a commit
that referenced
this pull request
Jun 17, 2021
* Improve unsupported block message for reusable block The unsupported block message has been updated and the convert to regular blocks button has been also included. * Update unsupported block message of reusable block
fluiddot
added a commit
that referenced
this pull request
Jun 18, 2021
* Release script: Update react-native-editor version to 1.55.0 * Release script: Update with changes from 'npm run core preios' * Release script: Update react-native-editor version to 1.55.1 * Release script: Update with changes from 'npm run core preios' * Fix: RNMobile borderRadius value setting (#32717) * [RNMobile] Improve unsupported block message for reusable block (#32618) * Improve unsupported block message for reusable block The unsupported block message has been updated and the convert to regular blocks button has been also included. * Update unsupported block message of reusable block * Update react-native-editor changelog Co-authored-by: Antonis Lilis <antonis.lilis@automattic.com> Co-authored-by: Enej Bajgoric <enej.bajgoric@automattic.com>
dcalhoun
added a commit
that referenced
this pull request
Jun 23, 2021
* Release script: Update react-native-editor version to 1.55.0 * Release script: Update with changes from 'npm run core preios' * Release script: Update react-native-editor version to 1.55.1 * Release script: Update with changes from 'npm run core preios' * Fix: RNMobile borderRadius value setting (#32717) * [RNMobile] Improve unsupported block message for reusable block (#32618) * Improve unsupported block message for reusable block The unsupported block message has been updated and the convert to regular blocks button has been also included. * Update unsupported block message of reusable block * Update react-native-editor changelog * Release script: Update react-native-editor version to 1.55.2 * Release script: Update with changes from 'npm run core preios' * Fix incorrect block insertion point after blurring post title (#32831) Selecting the title selection status within the same `useSelect` for reusable blocks caused the title selection status to become stale, due to the dependency array for the `useSelect` hook. The staleness caused the block insertion point to show up in the incorrect location after blurring the title text input. * Update changelog * Properly handle 404 errors while publishing Android artifacts (#32860) Co-authored-by: Antonis Lilis <antonis.lilis@automattic.com> Co-authored-by: Carlos Garcia <fluiddot@gmail.com> Co-authored-by: Enej Bajgoric <enej.bajgoric@automattic.com> Co-authored-by: Oguz Kocer <oguzkocer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3621Description
The unsupported block message has been updated and the convert to regular blocks button has been also included.
How has this been tested?
Screenshots
reusable-block-convert-bottom-sheet.mp4
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).