Disable "FSE" blocks in Widgets Editor #32761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
requested review from
adamziel,
draganescu,
kevin940726,
noisysocks,
talldan and
tellthemachines
as code owners
getdave
added
[Feature] Widgets Screen
getdave
changed the title
|
Can anyone help me to find all the entity based blocks? |
|
Size Change: +83 B (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
|
Now working on disabling in Customizer widgets. |
|
The "Site Logo" block doesn't work as well. Changes aren't saved from the widgets screens. |
|
I think reusable blocks would also need to be disabled (as they use entities), so I'm not sure how valid this option is. |
|
Yes, ➕ 1️⃣ for reusable block kind of making this option less viable. Nevertheless, we can come back later to all entity blocks. Disabling reusable blocks from widget areas now does not prevent them to be enabled later. |
|
@draganescu I've removed all the entity blocks including reusable blocks. I'll leave this PR here as an "option" if a better solution can't be found prior to 5.8. |
draganescu
added
[Status] Blocked
|
I don't think we can feasibly implement an entity saving flow in time for 5.8. I'm OK with adding support for these blocks in 5.8.x or 5.9. |
Does that mean we want to look to merge this? If so please could I have a review 🙏 🙇♂️ |
getdave
force-pushed
the
try/disable-fse-blocks-in-widgets-editor
branch
from
9daa3a1
to
73093e2
Compare
7 tasks
|
Tests failing...again. Unrelated. See #32887 |
adamziel
force-pushed
the
try/disable-fse-blocks-in-widgets-editor
branch
from
73093e2
to
94fe64e
Compare
|
Rebased, let's see if the tests pass |
|
👀 Thanks for rebase @adamziel. I'll merge |
getdave
force-pushed
the
try/disable-fse-blocks-in-widgets-editor
branch
from
94fe64e
to
57492c2
Compare
|
Rebasin' again... |
|
Follow up Issue here |
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 24, 2021
* Disable post-* and query* blocks * Disable remaining entity blocks and any experimental FSE blocks * Apply same disabling in the Customizer Widgets screen * Remove any registered reusable blocks from inserter * Fully disable reusable blocks in Widgets Editor * Fully disable reusable blocks in Widgets Editor * Improve constant usage
youknowriad
pushed a commit
that referenced
this pull request
Jun 24, 2021
* Disable post-* and query* blocks * Disable remaining entity blocks and any experimental FSE blocks * Apply same disabling in the Customizer Widgets screen * Remove any registered reusable blocks from inserter * Fully disable reusable blocks in Widgets Editor * Fully disable reusable blocks in Widgets Editor * Improve constant usage
draganescu
reviewed
Sep 7, 2021
| const disabledBlocks = [ | ||
| 'core/more', | ||
| 'core/freeform', | ||
| ...( ! ALLOW_REUSABLE_BLOCKS && [ 'core/block' ] ), |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently FSE blocks don't play well with the Widgets Editor because the required entities aren't there. Moreover, we'd need to support the multi-saving flows/UI from the Site Editor in order to support these blocks.
For 5.8 we could consider disabling all "FSE" blocks. This PR does just that.
It doesn't mean we go with this approach, but this PR allows it to be an option.
Fixes #32756
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).