Query Loop Patterns: Use plain div for wrapper element
#32867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryelle
added
[Feature] Patterns
youknowriad
added
the
Backport to WP 6.7 Beta/RC
ntsekouras
approved these changes
Jun 23, 2021
| <!-- wp:group {"tagName":"main","style":{"spacing":{"padding":{"top":"30px","right":"30px","bottom":"30px","left":"30px"}}},"layout":{"inherit":false}} --> | ||
| <main class="wp-block-group" style="padding-top:30px;padding-right:30px;padding-bottom:30px;padding-left:30px"><!-- wp:post-title {"isLink":true} /--> | ||
| <!-- wp:group {"style":{"spacing":{"padding":{"top":"30px","right":"30px","bottom":"30px","left":"30px"}}},"layout":{"inherit":false}} --> | ||
| <div class="wp-block-group" style="padding-top:30px;padding-right:30px;padding-bottom:30px;padding-left:30px"><!-- wp:post-title {"isLink":true} /--> |
There was a problem hiding this comment.
Wow, this mismatch with main and div has slipped through the introduction of the pattern 😄
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 24, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://core.trac.wordpress.org/ticket/53389#comment:14 — The Offset and Grid patterns for the Query Loop block use
mainas a content wrapper on the group block, but there can be at most one visiblemainon a page. Otherwise this is an invalid HTML page, and can be confusing for screen reader navigation.This change removes the tagName on the Offset and Grid patterns, so it defaults to a plain
div.To test, insert different query loops into a post and make sure it works as expected. There should be no user-facing changes.