-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Android e2e tests while we investigate foundational breakage #32934
Conversation
A `adb: no devices/emulators found` error is occurring and cause every run to fail. We intend to temporarily disable this job while we investigate the cause to avoid causing disruptions or confusion for contributors.
47ac707
to
edb581e
Compare
I see in the PR checks that the Android e2e tests job is still failing, shouldn't have disappeared with the changes? |
Yes, that was my intention. However, it looks like an empty |
I think you could disable it by adding this to the workflow (solution reference): |
…reakage" This reverts commit edb581e.
Previous approach did not work. Using the if configuration seems more appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good., so if CI is happy, then I am happy. 😄
…32934) * Disable Android e2e tests while we investigate foundational breakage A `adb: no devices/emulators found` error is occurring and cause every run to fail. We intend to temporarily disable this job while we investigate the cause to avoid causing disruptions or confusion for contributors. * Revert "Disable Android e2e tests while we investigate foundational breakage" This reverts commit edb581e. * Leverage if configuration to disable test Previous approach did not work. Using the if configuration seems more appropriate. * Fix conditional logic for GitHub Action
…32934) * Disable Android e2e tests while we investigate foundational breakage A `adb: no devices/emulators found` error is occurring and cause every run to fail. We intend to temporarily disable this job while we investigate the cause to avoid causing disruptions or confusion for contributors. * Revert "Disable Android e2e tests while we investigate foundational breakage" This reverts commit edb581e. * Leverage if configuration to disable test Previous approach did not work. Using the if configuration seems more appropriate. * Fix conditional logic for GitHub Action
Description
A
adb: no devices/emulators found
error is occurring and cause every run to fail. We intend to temporarily disable this job while we investigate the cause to avoid causing disruptions or confusion for contributors.How has this been tested?
Verify all CI checks succeed.
Screenshots
n/a
Types of changes
Tooling change.
Checklist:
*.native.js
files for terms that need renaming or removal).