Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Android e2e tests while we investigate foundational breakage #32934

Merged
merged 4 commits into from
Jun 23, 2021

Conversation

dcalhoun
Copy link
Member

Description

A adb: no devices/emulators found error is occurring and cause every run to fail. We intend to temporarily disable this job while we investigate the cause to avoid causing disruptions or confusion for contributors.

How has this been tested?

Verify all CI checks succeed.

Screenshots

n/a

Types of changes

Tooling change.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@dcalhoun dcalhoun marked this pull request as draft June 23, 2021 16:32
A `adb: no devices/emulators found` error is occurring and cause every
run to fail. We intend to temporarily disable this job while we
investigate the cause to avoid causing disruptions or confusion for
contributors.
@dcalhoun dcalhoun added [Type] Build Tooling Issues or PRs related to build tooling [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Jun 23, 2021
@fluiddot
Copy link
Contributor

I see in the PR checks that the Android e2e tests job is still failing, shouldn't have disappeared with the changes?

@dcalhoun
Copy link
Member Author

I see in the PR checks that the Android e2e tests job is still failing, shouldn't have disappeared with the changes?

Yes, that was my intention. However, it looks like an empty branches: [] configuration includes every branch, including this one, as indicated in the latest CI task run. I'll see if I can identify a better fix.

Screen Shot 2021-06-23 at 12 33 37

@fluiddot
Copy link
Contributor

I see in the PR checks that the Android e2e tests job is still failing, shouldn't have disappeared with the changes?

Yes, that was my intention. However, it looks like an empty branches: [] configuration includes every branch, including this one, as indicated in the latest CI task run. I'll see if I can identify a better fix.

Screen Shot 2021-06-23 at 12 33 37

I think you could disable it by adding this to the workflow (solution reference):
if: false # always skip job

Previous approach did not work. Using the if configuration seems more
appropriate.
@dcalhoun dcalhoun marked this pull request as ready for review June 23, 2021 18:37
@dcalhoun dcalhoun self-assigned this Jun 23, 2021
Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good., so if CI is happy, then I am happy. 😄

@dcalhoun dcalhoun merged commit d96b1ff into trunk Jun 23, 2021
@dcalhoun dcalhoun deleted the disable-android-e2e-tests branch June 23, 2021 19:21
@github-actions github-actions bot added this to the Gutenberg 11.0 milestone Jun 23, 2021
youknowriad pushed a commit that referenced this pull request Jun 24, 2021
…32934)

* Disable Android e2e tests while we investigate foundational breakage

A `adb: no devices/emulators found` error is occurring and cause every
run to fail. We intend to temporarily disable this job while we
investigate the cause to avoid causing disruptions or confusion for
contributors.

* Revert "Disable Android e2e tests while we investigate foundational breakage"

This reverts commit edb581e.

* Leverage if configuration to disable test

Previous approach did not work. Using the if configuration seems more
appropriate.

* Fix conditional logic for GitHub Action
youknowriad pushed a commit that referenced this pull request Jun 24, 2021
…32934)

* Disable Android e2e tests while we investigate foundational breakage

A `adb: no devices/emulators found` error is occurring and cause every
run to fail. We intend to temporarily disable this job while we
investigate the cause to avoid causing disruptions or confusion for
contributors.

* Revert "Disable Android e2e tests while we investigate foundational breakage"

This reverts commit edb581e.

* Leverage if configuration to disable test

Previous approach did not work. Using the if configuration seems more
appropriate.

* Fix conditional logic for GitHub Action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants