Improve insertion point and drag-n-drop in the widgets screen #32953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Type] Bug
kevin940726
force-pushed
the
fix/widgets-insertion-point
branch
from
bfe201b
to
9741301
Compare
|
Size Change: +1.9 kB (0%) Total Size: 1.04 MB
ℹ️ View Unchanged
|
kevin940726
commented
Jun 24, 2021
| @@ -59,7 +59,7 @@ function useInsertionPoint( { | |||
| let _destinationRootClientId = rootClientId; | |||
| let _destinationIndex; | |||
|
|
|||
| if ( insertionIndex ) { | |||
| if ( insertionIndex !== undefined ) { | |||
There was a problem hiding this comment.
This line fixes #32931. If insertionIndex is 0 then it short-circuit the logic below, which is the case when the block list is empty.
| * | ||
| * @return {boolean} Is dragging within the target element. | ||
| */ | ||
| const useIsDraggingWithin = ( elementRef ) => { |
There was a problem hiding this comment.
This file is copy-pasted from index.js.
| @@ -1,41 +1,72 @@ | |||
| $panel-title-height: 48px; | |||
There was a problem hiding this comment.
This is probably a bad idea but I don't have other solutions for now.
kevin940726
requested review from
noisysocks,
talldan,
adamziel,
tellthemachines,
draganescu and
getdave
noisysocks
added
the
Backport to WP 6.7 Beta/RC
talldan
approved these changes
Jun 25, 2021
packages/edit-widgets/src/blocks/widget-area/edit/inner-blocks.js
Outdated
Show resolved
Hide resolved
youknowriad
removed
the
Backport to WP 6.7 Beta/RC
youknowriad
pushed a commit
that referenced
this pull request
Jun 25, 2021
youknowriad
pushed a commit
that referenced
this pull request
Jun 25, 2021
|
Quick note that I'm now seeing a hover outline around panel areas (even when not dragging). Not sure if this could be related to this PR or something else that merged recently! cc @kevin940726 panel-outline.mov |
|
I assume it's not intended but I like it :))) |
|
It's not a bug introduced in this PR and it has patch (#33015) already :), but thanks for noting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #32652, fix #32931.
Expand the size of Widget Area's
InnerBlocksto the entire panel, so that dropping anywhere on that panel works. The trick is to use some hacky negativemargin-topandpadding-topcombo to achieve the effects. We also have to elevate the z-index of the title element so that clicking on it still works. However, we don't wantdragenteranddragleaveevents being triggered when dragging blocks onto the title element, hence we setpointer-events: noneto the title element while dragging.The widget area now shows a ring outline when a block is dragging upon it, to compensate that the blue line indicator is still kind of buggy and not easy to fix at the time (#32880).
c.c. @critterverse for design reviews♥️ 🙇♂️ !
How has this been tested?
Screenshots
Kapture.2021-06-24.at.18.39.04.mp4
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).