-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Prevent "Undo Level" after Setting Featured Image via Image Block #33057
Commits on Jun 28, 2021
-
Ignore edits to featured image in undo history
"editEntityRecord" includes an "undoIgnore: true" parameter that makes it possible to ignore an edit in the undo history. Reference: https://developer.wordpress.org/block-editor/reference-guides/data/data-core/#editEntityRecord With this commit, that parameter is set to true so that a new undo level *isn't* created after the featured image is updated via the app.
Siobhan committedJun 28, 2021 Configuration menu - View commit details
-
Copy full SHA for c5b3a9d - Browse repository at this point
Copy the full SHA c5b3a9dView commit details
Commits on Jul 8, 2021
-
Merge branch 'trunk' into fix/featured-button-undo-redo-functionality
Siobhan committedJul 8, 2021 Configuration menu - View commit details
-
Copy full SHA for 34a092c - Browse repository at this point
Copy the full SHA 34a092cView commit details
Commits on Jul 13, 2021
-
Merge branch 'trunk' into fix/featured-button-undo-redo-functionality
Siobhan committedJul 13, 2021 Configuration menu - View commit details
-
Copy full SHA for a75aa91 - Browse repository at this point
Copy the full SHA a75aa91View commit details
Commits on Jul 26, 2021
-
Merge branch 'trunk' into fix/featured-button-undo-redo-functionality
Siobhan committedJul 26, 2021 Configuration menu - View commit details
-
Copy full SHA for 8c7f6d9 - Browse repository at this point
Copy the full SHA 8c7f6d9View commit details
Commits on Jul 30, 2021
-
Add "featured image" section heading
By adding the settings for changing a featured image under their own section heading, it's being clearly separated from the other sections. This will help with the overall alignment/rhythm of the settings panel, which is important given we're adding an additional note.
Siobhan committedJul 30, 2021 Configuration menu - View commit details
-
Copy full SHA for 3611fa9 - Browse repository at this point
Copy the full SHA 3611fa9View commit details -
Add FooterMessageControl to settings
We're adding a note to the image block's setting to let users know that they won't be able to revert changes via the undo/redo button.
Siobhan committedJul 30, 2021 Configuration menu - View commit details
-
Copy full SHA for 958cbad - Browse repository at this point
Copy the full SHA 958cbadView commit details -
With this commit, we're aligning the featured button to the left and changing its border to display at the bottom. This follows design feedback here: #33057 (comment)
Siobhan committedJul 30, 2021 Configuration menu - View commit details
-
Copy full SHA for f574039 - Browse repository at this point
Copy the full SHA f574039View commit details
Commits on Aug 2, 2021
-
This commit updates the footer text following feedback from editorial.
Siobhan committedAug 2, 2021 Configuration menu - View commit details
-
Copy full SHA for 27f2623 - Browse repository at this point
Copy the full SHA 27f2623View commit details -
Remove bottom border from button
Siobhan committedAug 2, 2021 Configuration menu - View commit details
-
Copy full SHA for 89f15ac - Browse repository at this point
Copy the full SHA 89f15acView commit details -
Merge branch 'trunk' into fix/featured-button-undo-redo-functionality
Siobhan committedAug 2, 2021 Configuration menu - View commit details
-
Copy full SHA for 47fb632 - Browse repository at this point
Copy the full SHA 47fb632View commit details -
Remove bottom padding from button
Siobhan committedAug 2, 2021 Configuration menu - View commit details
-
Copy full SHA for 6ac5e79 - Browse repository at this point
Copy the full SHA 6ac5e79View commit details
Commits on Aug 6, 2021
-
Align button and footer text to top
With this commit, the content in the "Set as Featured" button and the footer message is aligned to the top of their containers. This will prevent flexbox from automatically adding spacing to the top of their containers, which goes against the design we want.
Siobhan committedAug 6, 2021 Configuration menu - View commit details
-
Copy full SHA for 604db68 - Browse repository at this point
Copy the full SHA 604db68View commit details -
Add title style to "Featured Image" panel
As we need to tweak the spacing around the panel's title, I've added a new "titleStyle" prop to the PanelBody component. That prop is then used to remove the bottom spacing for the "Featured Image" panel's title. The prop can now be re-used by anyone else who needs to tweak the title in a PanelBody in the future.
Siobhan committedAug 6, 2021 Configuration menu - View commit details
-
Copy full SHA for 795f309 - Browse repository at this point
Copy the full SHA 795f309View commit details -
Add top/bottom padding to button
Following the previous changes, this commit increases the height and "tappable area" of the "Set/Remove as Featured Image" button by adding both top and bottom padding.
Siobhan committedAug 6, 2021 Configuration menu - View commit details
-
Copy full SHA for fa0d455 - Browse repository at this point
Copy the full SHA fa0d455View commit details -
Configuration menu - View commit details
-
Copy full SHA for a14cbe6 - Browse repository at this point
Copy the full SHA a14cbe6View commit details -
Due to an error when merging, the code was referencing an old function name, "getSetFeaturedButton". It should instead reference the name name, "getFeaturedButtonPanel".
Siobhan committedAug 6, 2021 Configuration menu - View commit details
-
Copy full SHA for 658d005 - Browse repository at this point
Copy the full SHA 658d005View commit details -
For consistency with other selectors, this commit updates the name of "setFeaturedCellContainer" to "setFeaturedButtonCellContainer".
Siobhan committedAug 6, 2021 Configuration menu - View commit details
-
Copy full SHA for 2856d5a - Browse repository at this point
Copy the full SHA 2856d5aView commit details
Commits on Aug 9, 2021
-
Merge branch 'trunk' into fix/featured-button-undo-redo-functionality
Siobhan committedAug 9, 2021 Configuration menu - View commit details
-
Copy full SHA for 823df2b - Browse repository at this point
Copy the full SHA 823df2bView commit details -
Group FooterMessageControl into "Featured" panel
The placement of the component is moved within the main "Featured Image" panel, as this is more semantically correct than having the component within its own, separate panel.
Siobhan committedAug 9, 2021 Configuration menu - View commit details
-
Copy full SHA for 5662508 - Browse repository at this point
Copy the full SHA 5662508View commit details