CardBody: change default value of isScrollable to false
#33490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Feature] Component System
|
Size Change: +9 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
Looking at the changelog, the recent changes in the |
It all depends if those changes will get published to npm at the same time. Gutenberg 11.1 was already branched and it probably is going to be used as a base for the next npm publishing. If this PR isn't going to be cherry-picked to 11.1 then it might be valuable to include an individual changelog entry, otherwise you can probably skip it. |
Thank you @gziolo! Just to confirm, I was going to add an entry to the |
Yes, correct 👍🏻 |
sarayourfriend
approved these changes
Jul 16, 2021
gziolo
reviewed
Jul 19, 2021
| @@ -10,6 +10,7 @@ | |||
|
|
|||
| - `isPrimary`, `isSecondary`, `isTertiary` and `isLink` props in `Button` have been deprecated. Use `variant` instead ([#31713](https://github.com/WordPress/gutenberg/pull/31713)). | |||
| - `isElevated` prop in `Card` has been deprecated. Use `elevation` instead ([#32566](https://github.com/WordPress/gutenberg/pull/32566)). | |||
| - `isScrollable` prop in `CardBody` default value changed from `true` to `false` ([#33490](https://github.com/WordPress/gutenberg/pull/33490)) | |||
There was a problem hiding this comment.
Noting that if we publish WordPress packages to npm from Guteberg 11.1 this week we will have to move up this entry and put into its own section.
There was a problem hiding this comment.
Is there also going to be a new release of the components package (e.g. 14.2.0)?
There was a problem hiding this comment.
Yes, we didn't have it for a while but now that WordPress 5.8 should be out tomorrow, there is no blocker anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the default value of the
isScrollableprop in the<CardBody />component fromtruetofalseThis fix is one way to solve the bug highlighted in #33439, although it has the potential to introduce breaking changes too.
How has this been tested?
<CardBody />in Storybook:Screenshots
N/A
Types of changes
Fix + potential minor breaking change
Checklist:
*.native.jsfiles for terms that need renaming or removal).