Scripts: Use cssnano to minimize CSS files with build #33750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
force-pushed
the
update/scripts-cssnano
branch
2 times, most recently
from
ef37e94
to
c1b5607
Compare
gziolo
added
[Package] Scripts
gziolo
commented
Jul 29, 2021
2 tasks
gziolo
commented
Jul 29, 2021
|
Size Change: -1.35 kB (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/scripts-cssnano
branch
from
c1b5607
to
288b340
Compare
gziolo
commented
Jul 30, 2021
| @@ -24,6 +24,16 @@ const hasBabelConfig = () => | |||
| hasProjectFile( '.babelrc' ) || | |||
| hasPackageProp( 'babel' ); | |||
|
|
|||
| // See https://cssnano.co/docs/config-file. | |||
| const hasCssnanoConfig = () => | |||
There was a problem hiding this comment.
I discovered in the source code that the list of supported file names is longer that in the docs.
|
@gziolo Wasn't this CSSNano feature included in 17.1.0. I couldn't achieve it! |
|
No, it's still in the development |
|
@gziolo I noticed this PR (and one other) appearing under "Enhancements" in the auto-changelog. I wonder is there a better label we could assign to changes like this that are "Tooling" but not necessarily Build Tooling? |
|
@getdave, I'm open to improvements in this area. Sometimes it's very hard to match existing labels with work that doesn't impact production code. This PR is tricky as well, it was an existing behavior when using I'm sure about one change, we should at least rename |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #33676 and the comment from @ocean90 #33676 (comment):
How has this been tested?
I created a custom block with:
npx wp-create-block example --no-wp-scripts cd example ../node_modules/.bin/wp-scripts buildI updated used CSS files to end with
.cssto ensure that the output is properly minimized.I also ensured that the output of CSS files isn't minified in the dev mode with:
I added
cssnano.config.jsfile in the root folder of the project with the following content:I also had to install `cssnano-preset-default' with:
When I run:
I can see that comments in the CSS files are preserved. It means that the custom config is properly loaded when present.
Types of changes
Enhancement.
Checklist:
*.native.jsfiles for terms that need renaming or removal).