Skip customizing widgets inspector e2e test #33875
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.08 MB ℹ️ View Unchanged
|
|
I think I know why this is failing. (The screenshot doesn't really help here, we probably need a screencast for these) During closing the inspector and going back to the editor, the transition is making the blocks positioning in an intermediate state. Since the toolbar is still opened, it could sometimes also be positioned in the wrong place according to intermediate state of the block. We can (1) wait for the transition to finished, or (2) disable the transition (#32024), or (3) delay showing the toolbar until the transition is finished. The easiest way right now is probably (1), we can go for that for now and look for alternatives later. |
7 tasks
|
Oh cool, let's close this then 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is probably one of the last flaky tests at the moment.
Here's some examples of failures https://github.com/WordPress/gutenberg/runs/3232443026
It seems the dropdown menu is not opening for some reason.