Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimensions Support: Switch dimensions block support back to using spacing key #34030

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

aaronrobertshaw
Copy link
Contributor

Description

This reverts the registration of dimensions block support back to using the spacing key. This is to ensure that it still aligns with the previous registration of block support within WordPress 5.8.

How has this been tested?

  • Ran npm run wp-env run phpunit 'phpunit -c /var/www/html/wp-content/plugins/gutenberg/phpunit.xml.dist --verbose --filter stylesheet /var/www/html/wp-content/plugins/gutenberg/phpunit/class-wp-theme-json-test.php'
  • Ran npm run test-unit:watch packages/block-editor/src/hooks/test/style.js
  • Added padding via block supports to dynamic block e.g. site-tagline

Types of changes

Bug fix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@aaronrobertshaw aaronrobertshaw added [Type] Bug An existing feature does not function as intended [Feature] Block API API that allows to express the block paradigm. labels Aug 12, 2021
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 12, 2021
@oandregal oandregal merged commit 0acd6c7 into trunk Aug 12, 2021
@oandregal oandregal deleted the fix/dimensions-block-support-registration branch August 12, 2021 08:13
@github-actions github-actions bot added this to the Gutenberg 11.4 milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block API API that allows to express the block paradigm. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants