Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToolsPanel: switch to plus icon when no controls present in panel body #34107

Merged
merged 12 commits into from
Oct 14, 2021
Merged

ToolsPanel: switch to plus icon when no controls present in panel body #34107

merged 12 commits into from
Oct 14, 2021

Commits on Oct 13, 2021

  1. When there are no selected controls within a ToolsPanel, change the i… 

    …con to a plus symbol. This is to indicate to the user that they can add controls to the panel.
    @ramonjd
    ramonjd committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    c6c73eb View commit details
    Browse the repository at this point in the history

  2. Moving business logic into the hook

    @ramonjd
    ramonjd committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    1186edf View commit details
    Browse the repository at this point in the history

  3. Ensure that optional controls, when hidden and available, trigger the… 

    … plus icon in the ToolsPanel header.

Updated stories.
    @ramonjd
    ramonjd committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    6b2b974 View commit details
    Browse the repository at this point in the history

  4. updating variable name to make it clearer that we want to track if op… 

    …tional items are available at all *and* if so, are they hidden
    @ramonjd
    ramonjd committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    c1b84b2 View commit details
    Browse the repository at this point in the history

  5. This commit adds a variable aria-label to the tools panel header menu… 

    … button to describe the element and its intended effects.

Added component tests.
    @ramonjd
    ramonjd committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    c46a415 View commit details
    Browse the repository at this point in the history

  6. Changing copy from "Show" to "View" 

    Updating tests
    @ramonjd
    ramonjd committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    6045abc View commit details
    Browse the repository at this point in the history

  7. Renaming areAllOptionalControlsHidden variable and adding it as a p… 

    …roperty to the ToolsPanelContext type

Modified default value of areAllOptionalControlsHidden and updated comments
    @ramonjd
    ramonjd committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    33b0054 View commit details
    Browse the repository at this point in the history

  8. Make areAllOptionalControlsHidden required on the ToolsPanelContent… 

    … object.
    @ramonjd
    ramonjd committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    33d50cc View commit details
    Browse the repository at this point in the history

  9. Update packages/components/src/tools-panel/test/index.js 

    Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com>
    @ramonjd @aaronrobertshaw
    ramonjd and aaronrobertshaw committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    08a6863 View commit details
    Browse the repository at this point in the history

  10. Add custom fixtures for optional control props in order to test the p… 

    …anel header icon toggle in isolation from the other tests.
    @ramonjd
    ramonjd committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    5b4dd79 View commit details
    Browse the repository at this point in the history

  11. Update packages/components/src/tools-panel/stories/index.js 

    Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com>
    @ramonjd @aaronrobertshaw
    ramonjd and aaronrobertshaw committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    cdc1702 View commit details
    Browse the repository at this point in the history

  12. Consolidating comment and reinstating false as the default value fo… 

    …r the state var `areAllOptionalControlsHidden`
    @ramonjd
    ramonjd committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    75e37a3 View commit details
    Browse the repository at this point in the history