Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place the table of content feature in the header. #3459

Merged
merged 2 commits into from
Nov 14, 2017

Conversation

mtias
Copy link
Member

@mtias mtias commented Nov 13, 2017

Making some tweaks to the placement of the table of contents button.

image

Get rid of custom button and CSS. Use IconButton with tooltip.
@mtias mtias added General Interface Parts of the UI which don't fall neatly under other labels. Design [Feature] Document Settings Document settings experience labels Nov 13, 2017
@codecov
Copy link

codecov bot commented Nov 13, 2017

Codecov Report

Merging #3459 into master will decrease coverage by 0.54%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3459      +/-   ##
==========================================
- Coverage   33.86%   33.31%   -0.55%     
==========================================
  Files         253      256       +3     
  Lines        6736     6852     +116     
  Branches     1223     1251      +28     
==========================================
+ Hits         2281     2283       +2     
- Misses       3756     3842      +86     
- Partials      699      727      +28
Impacted Files Coverage Δ
editor/modes/visual-editor/index.js 0% <ø> (ø) ⬆️
editor/header/header-toolbar/index.js 0% <0%> (ø) ⬆️
editor/table-of-contents/index.js 0% <0%> (ø) ⬆️
editor/modes/visual-editor/block.js 0% <0%> (ø) ⬆️
editor/sidebar/block-inspector-panel/index.js 0% <0%> (ø)
editor/components/block-inspector/index.js 14.28% <0%> (ø)
...or/components/block-inspector/advanced-controls.js 4.76% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b971d42...1d0ca97. Read the comment docs.

<Dashicon icon="info" />
</button>
icon="admin-page"
label={ __( 'Information' ) }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could use some better explanation.

@afercia
Copy link
Contributor

afercia commented Nov 13, 2017

Moving it away from the content region is a nice improvement thanks 🙂

This change would also partially solve #3216 because it adds an aria-label (and I guess also a tooltip. Maybe the wording __( 'Information' ) could be improved, but that can be reviewed later, see #2387
Would be great to add also an aria-expanded attribute too.

@karmatosed
Copy link
Member

Looks great, it's an improvement and opens up the editing area.

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. 👍

@mtias
Copy link
Member Author

mtias commented Nov 14, 2017

@afercia yes, thought you might appreciate it :) Agree on the wording, left a comment about it. Also added expanded role.

@mtias mtias merged commit e0b29b5 into master Nov 14, 2017
@mtias mtias deleted the update/doc-outline-placement branch November 14, 2017 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Document Settings Document settings experience General Interface Parts of the UI which don't fall neatly under other labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants