-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Place the table of content feature in the header. #3459
Conversation
Get rid of custom button and CSS. Use IconButton with tooltip.
Codecov Report
@@ Coverage Diff @@
## master #3459 +/- ##
==========================================
- Coverage 33.86% 33.31% -0.55%
==========================================
Files 253 256 +3
Lines 6736 6852 +116
Branches 1223 1251 +28
==========================================
+ Hits 2281 2283 +2
- Misses 3756 3842 +86
- Partials 699 727 +28
Continue to review full report at Codecov.
|
editor/table-of-contents/index.js
Outdated
<Dashicon icon="info" /> | ||
</button> | ||
icon="admin-page" | ||
label={ __( 'Information' ) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could use some better explanation.
Moving it away from the content region is a nice improvement thanks 🙂 This change would also partially solve #3216 because it adds an |
Looks great, it's an improvement and opens up the editing area. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. 👍
@afercia yes, thought you might appreciate it :) Agree on the wording, left a comment about it. Also added expanded role. |
Making some tweaks to the placement of the table of contents button.