Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Require '@wordpress/' import path for application entry points #3533

Merged
merged 1 commit into from
Nov 17, 2017

Conversation

mcsf
Copy link
Contributor

@mcsf mcsf commented Nov 17, 2017

Description

See #3531.

How Has This Been Tested?

Attempt to change any import from import { Foo } from '@wordpress/element' to import { Foo } from 'element'. Try the same for other Gutenberg entry points (e.g. blocks, i18n).

Screenshots (jpeg or gifs if applicable):

screen shot 2017-11-17 at 12 56 17

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.

@mcsf mcsf requested a review from gziolo November 17, 2017 12:57
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 👍 Thanks!

@mcsf mcsf merged commit 50cbf5d into master Nov 17, 2017
@gziolo gziolo deleted the update/eslint-entry-paths branch November 17, 2017 13:47
@mtias mtias mentioned this pull request Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants