Rich text: fix internal paste across multiline and single line instances #35416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +4.07 kB (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
ellatrix
added
the
[Type] Regression
6 tasks
mcsf
approved these changes
Oct 8, 2021
There was a problem hiding this comment.
Thanks for the quick fix, this makes more sense to me!
Related to this, I noticed in createFromMultilineElement that currentWrapperTags is documented as a boolean (in the @param type and in the English description), but used as an array. Could you patch it before merging this?
packages/block-editor/src/components/rich-text/use-paste-handler.js
Outdated
Show resolved
Hide resolved
…er.js Co-authored-by: Miguel Fonseca <miguelcsf@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #33078.
Problem: the multilineTag context is lost when pasting across rich text instances. This causes the HTML to be parsed wrongly.
Solution: pass the multilineTag through the transferData, so we can recreate the rich text value from the HTML correctly.
I also added a function to replace line separators with line breaks when pasting a multiline value into a single line instance and to replace line breaks with line separators when pasting a single line value into a multiline instance. The latter is already used for external paste.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).