Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment Template block: Handle nested comments #36065

Merged
merged 37 commits into from
Dec 6, 2021
Merged

Comment Template block: Handle nested comments #36065

merged 37 commits into from
Dec 6, 2021

Commits on Dec 3, 2021

  1. Comments Query: Use discussion settings as a defult for queryPerPage

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    fb025fb View commit details
    Browse the repository at this point in the history

  2. Comments Query: Make <ul> into <ol>

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    bd78b9c View commit details
    Browse the repository at this point in the history

  3. Comment Template: Add styles

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    9d86e2b View commit details
    Browse the repository at this point in the history

  4. Comment Template: Handle the discussion settings

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    b5ee661 View commit details
    Browse the repository at this point in the history

  5. Fix whitespace

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    42ceb0b View commit details
    Browse the repository at this point in the history

  6. Comments template: Stop using comments_per_page

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    f8f4436 View commit details
    Browse the repository at this point in the history

  7. Comments Template: Update the fixtures

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    7b552de View commit details
    Browse the repository at this point in the history

  8. Comments Template: Update JS-side implementation to fix bugs with foc… 

    …us and add tests
    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    4ae2cbf View commit details
    Browse the repository at this point in the history

  9. Comments Template: Update styles and tests

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    d1b1723 View commit details
    Browse the repository at this point in the history

  10. Comment Template: Add comments to imports because eslint

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    25951a4 View commit details
    Browse the repository at this point in the history

  11. Comments Template: Add better comments

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    6d461e1 View commit details
    Browse the repository at this point in the history

  12. Coment Template: Refactor JS + add better comments

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    4574b50 View commit details
    Browse the repository at this point in the history

  13. Comment Template: Fix JSDoc

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    2dd4dea View commit details
    Browse the repository at this point in the history

  14. Comment Template: Add nested comments on PHP side

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    2aa2f71 View commit details
    Browse the repository at this point in the history

  15. Comment Template: Add css to block-library CSS file.

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    54ad6c4 View commit details
    Browse the repository at this point in the history

  16. Comment Template: Generate correct attributes

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    7c83c30 View commit details
    Browse the repository at this point in the history

  17. Just reformat

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    08a3f22 View commit details
    Browse the repository at this point in the history

  18. Comment Template: Revert useless rename

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    8ca6657 View commit details
    Browse the repository at this point in the history

  19. Remove unnecesary isset() call 

    Co-authored-by: Greg Ziółkowski <grzegorz@gziolo.pl>
    @michalczaplinski @gziolo
    michalczaplinski and gziolo committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    a707338 View commit details
    Browse the repository at this point in the history

  20. Move RenderComments to inside CommentTemplateInnerBlocks

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    2db7cac View commit details
    Browse the repository at this point in the history

  21. Fix typo

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    9226e01 View commit details
    Browse the repository at this point in the history

  22. Comment Template: Simplify mapping over comments

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    3b57775 View commit details
    Browse the repository at this point in the history

  23. Comment Template: Prefix functions with block_core_comment_template

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    e4e18fd View commit details
    Browse the repository at this point in the history

  24. Comment Template: Refactor 

    Replace the custom convert_to_tree with calls to ::get_children()
    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    1c34cab View commit details
    Browse the repository at this point in the history

  25. Comment Template: Change how we destructure children in CommentTempla… 

    …teInnerBlocks
    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    8a8e9b5 View commit details
    Browse the repository at this point in the history

  26. Comment Template: Add PHP test cases

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    13216ef View commit details
    Browse the repository at this point in the history

  27. Comment Template: Rename RenderComments to CommentList

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    737a123 View commit details
    Browse the repository at this point in the history

  28. Comment Template: Refactor to make ConmmentTemplateInnerBlock more re… 

    …adable
    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    a352e05 View commit details
    Browse the repository at this point in the history

  29. Comment Template: Handle queryPerPage correctly on the JS side

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    712a9c1 View commit details
    Browse the repository at this point in the history

  30. Comment Template: Remove the id from the comment object

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    802e379 View commit details
    Browse the repository at this point in the history

  31. Comment Template: Remove tearDown() from PHP tests

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    4913a8c View commit details
    Browse the repository at this point in the history

  32. Comment Template: Add comment to clarify that build step adds 'gutenb… 

    …erg_*' prefix to functions
    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    6c4fd11 View commit details
    Browse the repository at this point in the history

  33. Comment Template: Rename the blockContexts to comments

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    49cbc42 View commit details
    Browse the repository at this point in the history

  34. Comment Template: Add context embed

    @michalczaplinski
    michalczaplinski committed Dec 3, 2021
    Configuration menu
    Copy the full SHA
    71c7d00 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2021

  1. Fix code styling issues

    @gziolo
    gziolo authored Dec 6, 2021
    Configuration menu
    Copy the full SHA
    ebdd15f View commit details
    Browse the repository at this point in the history

  2. Fix code styling issues

    @gziolo
    gziolo authored Dec 6, 2021
    Configuration menu
    Copy the full SHA
    2e1ce22 View commit details
    Browse the repository at this point in the history

  3. Improve JSDoc for convertToTree function

    @gziolo
    gziolo authored Dec 6, 2021
    Configuration menu
    Copy the full SHA
    d56656b View commit details
    Browse the repository at this point in the history