Background Tools: Move background color settings to a different panel #36121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
the
[Feature] Design Tools
|
Size Change: +25 B (0%) Total Size: 1.08 MB
ℹ️ View Unchanged
|
|
Thanks for the PR, works as intended, I see the background here: As an interim step, this also already feels like it's surfacing some limitations:
While it does start work on #16479, I'm not sure this step on its own is sufficient. While different background properties (featured image, crop, position, repeat etc) do suggest a separate panel, until those controls come to bear it might not be worth it to separate out the color. The mockups in #35093 might also open up some new avenues for how to group colors and color tools. CC: @critterverse and @javierarce as I believe they've looked into background tools and I would defer to them on any approach taken here. |
|
Thanks for the review. I'm happy to continue to add more to this, for example adding support for featured images in backgrounds, but I didn't want to make a massive PR! |
|
I agree with @jasmussen, this is a potentially good change, but it should be paired with more functionality. In that sense, I personally would defer the release of this PR until we have a clearer vision of how we will integrate the existing and new functionalities. |
I agree with these notes from @jasmussen, and am wondering if there may be an opportunity to combine the new Background panel with the Color panel work being done in #35093. @javierarce has some explorations around this in his blog post Interaction of Color, where the Background panel could be a popover panel that’s accessible from the Color panel:
^ Seems like options such as using the Featured Image could work nicely in this context. |
|
Visaully we can potentially consolidate some of the details towards using the ItemGroup design, perhaps up to and including the background, that would let it share a little DNA with Global Styles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a first step towards #16479. It moves the background color control to a separate panel. This is a precursor to #24660.
How has this been tested?
Using TwentyTwentyTwo
Screenshots
Types of changes
Breaking change
Checklist:
*.native.jsfiles for terms that need renaming or removal).