Move WP_REST_Block_Navigation_Areas_Controller from Gutenberg to Core. #36374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to use /wp/v2 namespace.
anton-vlasenko
requested review from
nerrad,
spacedmonkey and
TimothyBJacobs
as code owners
|
Size Change: +602 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
We have to use /wp/v2 namespace.
|
@anton-vlasenko Do you want a review for this yet? |
anton-vlasenko
added
[Type] Enhancement
|
@spacedmonkey Yes, please :) |
anton-vlasenko
changed the title
| @@ -37,7 +37,8 @@ public function register_routes() { | |||
| 'permission_callback' => array( $this, 'get_items_permissions_check' ), | |||
| 'args' => $this->get_collection_params(), | |||
| ), | |||
| 'schema' => array( $this, 'get_public_item_schema' ), | |||
| 'schema' => array( $this, 'get_public_item_schema' ), | |||
| 'allow_batch' => array( 'v1' => true ), | |||
There was a problem hiding this comment.
We are now following this pattern.
WordPress/wordpress-develop@ecf1d6a
So this should be
'allow_batch' => $this->allow_batch,
There was a problem hiding this comment.
Good to know.
This task is already merged, but I will be using 'allow_batch' => $this->allow_batch from now on.
|
I posted some comments on #36178. Like someone to look at those comments. |
7 tasks
|
Going to merge this now so as to fix CI which is failing now that Core has the endpoint committed. |
noisysocks
approved these changes
Nov 11, 2021
noisysocks
deleted the
add/move-gutenberg-navigation-endpoint-to-core
branch
noisysocks
added
the
Backport to WP 6.7 Beta/RC
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 11, 2021
#36374) * Move WP_REST_Block_Navigation_Areas_Controller from Gutenberg to Core. We have to use /wp/v2 namespace. * Move WP_REST_Block_Navigation_Areas_Controller from Gutenberg to Core. We have to use /wp/v2 namespace. * Enable batching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to change the route of the
__experimental/block-navigation-areasREST API endpoint.It has to be renamed to
/wp/v2/block-navigation-areasbecause we have to merge theWP_REST_Block_Navigation_Areas_Controllercontroller into Core.Also, this PR enables batching for this new (old) REST route.
How has this been tested?
Gutenberg -> Experimentsand enableNavigation Screen.Gutenberg -> Navigationpage.Screenshots
No screenshots are needed.
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).