Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Extract Undo/Redo buttons as reusable components #3640

Merged
merged 1 commit into from
Nov 24, 2017

Conversation

youknowriad
Copy link
Contributor

Extract a reusable Undo/Redo components to the editor/components folder.
Needed to be able to separate the edit-post and editor module

Expect some similar PRs today, I'm going to merge them as soon as the tests pass, they consist of moving some files around.

Testing instructions

  • Check that the undo/redo buttons work

@youknowriad youknowriad self-assigned this Nov 24, 2017
@youknowriad youknowriad force-pushed the update/extract-undo-redo-buttons branch from 26ea0e4 to 9e9ba3b Compare November 24, 2017 10:33
@codecov
Copy link

codecov bot commented Nov 24, 2017

Codecov Report

Merging #3640 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3640      +/-   ##
==========================================
- Coverage   36.85%   36.83%   -0.03%     
==========================================
  Files         268      270       +2     
  Lines        6640     6644       +4     
  Branches     1201     1201              
==========================================
  Hits         2447     2447              
- Misses       3541     3545       +4     
  Partials      652      652
Impacted Files Coverage Δ
editor/components/editor-history/redo.js 0% <0%> (ø)
editor/components/editor-history/undo.js 0% <0%> (ø)
editor/edit-post/header/header-toolbar/index.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b81cdf6...9e9ba3b. Read the comment docs.

@youknowriad youknowriad merged commit dfdf9d0 into master Nov 24, 2017
@youknowriad youknowriad deleted the update/extract-undo-redo-buttons branch November 24, 2017 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant