[RNMobile] Enable child block caption field to be hidden by parent blocks #36618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 18, 2021 13:14
If a parent block is hiding child block controls, we can reasonable deduce that that would include the option to edit the child block's caption. This commit builds on the work done in #36371 to detect if a parent block is hiding child block controls via the '__experimentalHideChildBlockControls' block supports.
The 'hideCaption' variable introduced with this commit will hide the block caption in cases where parent block's set the '__experimentalHideChildBlockControls' block support to true.
SiobhyB
added
the
Mobile App - i.e. Android or iOS
SiobhyB
added
the
[Feature] Nested / Inner Blocks
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
2 tasks
|
@guarani, I'd be super interested to hear whether you think my reasoning for using the existing block support makes sense here or if you think it'd be better to come up with a separate approach. 🙇♀️ |
guarani
reviewed
Nov 18, 2021
As the purpose of this code may not be immediately clear, given it assumes knowledge of inner blocks, I've added a clarifying comment.
This was referenced Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: wordpress-mobile/gutenberg-mobile#4190
Gutenberg Mobile:wordpress-mobile/gutenberg-mobile#4256Description
This PR provides a way for parent blocks to hide the block caption component (if used) in any inner child block.
The code builds on the work done in #36371, which introduced a new
__experimentalHideChildBlockControlsblock support. The purpose of the new block support is to hide child block settings/controls, which is helpful in cases when native blocks need to customize inner blocks. A further outline of the use case for this support can be found here.With this PR, the block caption component now also listens for
__experimentalHideChildBlockControls. If it is set to true then any captions are hidden from child blocks.The thoughts behind using an existing block support, instead of creating a new one, are as follows:
How has this been tested?
Note: The Gallery block is being used as a proof of concept here and for the purposes of testing. We are not planning to actually remove the caption from its inner Image blocks. The following steps can be repurposed for any block using inner blocks and a caption field.
Prequisite: Enable the flag for the refactored Gallery block. on mobile. At the time of writing, the way to enable the block on the Gutenberg Mobile demo app is to comment out this section of code.
"__experimentalHideChildBlockControls": trueto the Gallery block'sblock.jsonfile. It should be added to the block supports object here.We should also test other blocks that make use of the block caption component to verify there are no regressions. Those blocks are all native and include:
Screenshots
Types of changes
This PR introduces a non-breaking change, with the following high-level overview of the code:
__experimentalHideChildBlockControlsis true has been added to the block caption component'sshouldDisplayboolean. This will now enable parent blocks to set the value totrueif the caption should be hidden from child blocks.hasBlockSupportis used to achieve this.Checklist:
*.native.jsfiles for terms that need renaming or removal).