Update featured image placeholder graphic. #36712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Block] Post Featured Image
7 tasks
|
Size Change: -63 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
|
Thank you! I'll give this a bit to see if Pablo has bandwidth to chime in, then I'll land it. |
|
Sleek! Kudos, again. |
|
Is this something that is meant for 5.9? |
|
Yes |
youknowriad
added
the
Backport to WP 6.7 Beta/RC
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 29, 2021
7 tasks
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #36517 (comment).
The mountain range works well for the site logo placeholder as it matches the icon. For the featured image, it becomes less clear what it's about. This PR takes feedback from above and embraces classic DTP layout principles to create a literal placeholder for the Featured Image block:
Note, the diagonal here is intentionally set to stretch (the dashed line should still be correct and update its spacing to match resized dimensions). But if we wanted to, I could make it not stretch:
Note that I've also updated the opacity of the dashed line, including for the featured image:
How has this been tested?
Try the featured image and site logo blocks.
Checklist:
*.native.jsfiles for terms that need renaming or removal).