Navigation: Try inheriting orientation in setup state. #36778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
Size Change: +236 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
This was referenced Nov 24, 2021
jasmussen
added
the
Backport to WP 6.7 Beta/RC
7 tasks
noisysocks
added
[Type] Bug
|
This looks like a bug fix to me as the screenshot you have in "Before" looks broken. We can include it in WP 5.9 if this is merged today (Monday). I'll begin backporting merged PRs on Tuesday morning Australian Eastern time 🙂 |
|
@noisysocks asked me to review/test this to see if it's ready for 5.9. I noticed the branch is a few weeks old, I think the PR probably needs some updates to be ready for 5.9. I tested on a rebased version of the branch and here are a few observations (using Mac OS/Brave):
|
talldan
added
Backport to WP Minor Release
|
I think it's probably best to aim for 5.9.1 for this, so I've swapped the labels. Appreciate the work here @jasmussen 👍 |
|
I was about to suggest that this one has been in need of a review for a bit, and is mostly UX buggy, so it's not worth the risk to land at this point. I'll rebase and shepard along instead. |
|
This PR also fixes the following focus rectangle bug: |
|
Can I get a green check on this one? |
getdave
approved these changes
Jan 28, 2022
| @@ -271,20 +280,8 @@ $color-control-label-height: 20px; | |||
| } | |||
|
|
|||
| &:not(.is-loading) { | |||
| // Don't show the preview boxes for an empty nav block, | |||
| // but be technically present to help size the empty state. | |||
| // Don't show the preview boxes for an empty nav block. | |||
There was a problem hiding this comment.
What are the "preview boxes"? Anyway to be more specific here to add clarity?
There was a problem hiding this comment.
Oh good one! That actually suggests this needs a quick look again after the rebase! I'll take a look, thank you!
jasmussen
force-pushed
the
try/navigation-inherit-orientation
branch
from
6697b67
to
c38fded
Compare
|
Alright, I've refactored this to be simpler, notably due to the removal of the blobs and the fact that the The removal of the blobs also open up the question of what to show for an unselected, empty, vertical navigation block. Which as of this PR is the same as when it's horizontal. At this moment, I feel this is right: the block is empty, and so it shouldn't necessarily take up extra vertical space. At the same time, it does cause a vertical jump when selected, which is generally something to avoid. I'll leave the "In progress" label on the PR, and see if a good solution presents itself after lunch. |
|
Alright, I've pushed a min-height, so things look good now: This is now a bigger change, though, so I'd appreciate a re-review before landing it. Secondly, as more placeholders that feature unselected previews (see Site Logo, Featured Image, etc.) move towards this more minimalist dashed metaphor, I suspect there's a generic refactor of the components involved in all these, that could clean up a great deal of the code. That would also let us leverage the generic loading spinner we have. That's a separate conversation, though, but one worth having at some point. |
vcanales
approved these changes
Jan 31, 2022
|
Alright, as an extension of the change to nav blobs, this makes sense to me to land as is. I'm actually going to remove the backport label, because this one no longer makes sense to backport if we don't also backport the placeholder change. |
jasmussen
removed
the
Backport to WP Minor Release
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The navigation setup state used to have a vertical orientation, relying on an
is-verticalclass. That class has been retired with the flex layout orientation, so this needs a different approach. This PR takes a step towards getting it to work. Before:After:
I suspect the placeholder for the navigation block will need a bit more work, notably around the gray blobs. Feedback time and again have suggested they look like a "loading state", when in fact they are meant to represent an unconfigured block. In that light, I'd like to explore separately to remove those blobs entirely. (In retiring these, it would also remove the layout shift that happens when selecting and deselecting the block!)
How has this been tested?
Insert a navigation block, then test changing the orientation.
Checklist:
*.native.jsfiles for terms that need renaming or removal).