-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Uneditable duotone palette on the palette gradient panel #36920
Merged
jorgefilipecosta
merged 1 commit into
trunk
from
add/uneditable-duotone-palette-on-the-palette-gradient-panel
Nov 29, 2021
Merged
Add: Uneditable duotone palette on the palette gradient panel #36920
jorgefilipecosta
merged 1 commit into
trunk
from
add/uneditable-duotone-palette-on-the-palette-gradient-panel
Nov 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
labels
Nov 26, 2021
Size Change: +153 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
add/uneditable-duotone-palette-on-the-palette-gradient-panel
branch
2 times, most recently
from
November 29, 2021 12:33
3003286
to
309aaf0
Compare
jorgefilipecosta
force-pushed
the
add/uneditable-duotone-palette-on-the-palette-gradient-panel
branch
from
November 29, 2021 12:47
309aaf0
to
8bbfe05
Compare
jorgefilipecosta
deleted the
add/uneditable-duotone-palette-on-the-palette-gradient-panel
branch
November 29, 2021 13:24
noisysocks
pushed a commit
that referenced
this pull request
Nov 30, 2021
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
Pull request that needs to be backported to the WordPress major release that's currently in beta
label
Nov 30, 2021
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Global Styles
Anything related to the broader Global Styles efforts, including Styles Engine and theme.json
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds uneditable duotone palette information on the palette gradient panel.
It also adds clearable flag (defaulting to true) to the DuotonePicker component, to match what the other color/palette related components already have.
Part of: #36543
How has this been tested?
I opened the global styles sidebar and verified the duotones are shown as the way the following screenshot shows.
Screenshots