Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme.json: sort keys alphabetically #36968

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Nov 29, 2021

Related WordPress core PR WordPress/wordpress-develop#1973

This PR sorts the keys in theme.json alphabetically, so it's easier to compare with WordPress core code.

@oandregal oandregal changed the title Sort keys alphabetically theme.json: sort keys alphabetically Nov 29, 2021
@oandregal oandregal self-assigned this Nov 29, 2021
@oandregal oandregal added Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Nov 29, 2021
@oandregal oandregal changed the title theme.json: sort keys alphabetically theme.json: sort keys alphabetically Nov 29, 2021
@oandregal oandregal merged commit f61fb88 into trunk Nov 29, 2021
@oandregal oandregal deleted the update/theme-json-keys-sort-alphabetically branch November 29, 2021 18:40
@github-actions github-actions bot added this to the Gutenberg 12.1 milestone Nov 29, 2021
@oandregal
Copy link
Member Author

This PR does not need to be ported to WordPress core because the changes are already at WordPress/wordpress-develop#1973 However, it needs to be ported to the Gutenberg wp/trunk branch.

@oandregal oandregal added the [Type] Code Quality Issues or PRs that relate to code quality label Nov 29, 2021
@noisysocks noisysocks removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants