Gallery: remove placeholder border #37050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Bug
|
Size Change: -41 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
glendaviesnz
approved these changes
Dec 2, 2021
ramonjd
force-pushed
the
remove/gallery-image-placeholder-border
branch
4 times, most recently
from
a759bae
to
6593d1d
Compare
ramonjd
force-pushed
the
remove/gallery-image-placeholder-border
branch
from
6593d1d
to
0520ddb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that we have Image Blocks in Galleries, there's the possibility that Image Block placeholders will also turn up.
To make focus behaviour consistent with the Image Block, this small PR removes the persistent border from the Image Block placeholder in the Gallery Block.
The Image Block placeholder won't appear very often in the Gallery Block, but it might if we delete an image from the media library. I first came across this while trying deal with deleted images in the Image Block
The blue border for selected blocks is taken care of by default.
Testing
Create a new post
Insert the following gallery code:
Check that the extra border on the placeholder does not appear.
Example:
I've tested with v1 galleries as well to make sure. Seeing as Image Blocks do not appear in v1 galleries anyway, I think it's pretty safe.
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).