FSE: Fix template resolution to give precedence to child theme PHP templates over parent theme block templates with equal specificity #37074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
approved these changes
Dec 3, 2021
youknowriad
added
the
Backport to WP 6.7 Beta/RC
|
This is already in Core but I'm adding the backport to label to sync wp/trunk branch. |
…mplates over parent theme block templates with equal specificity
noisysocks
force-pushed
the
backbackport/child-theme-php-template-precedence-over-parent-theme-block-template
branch
from
23f3cc3 to
71bc8d0
Compare
|
I rebased this to (hopefully) fix failing tests. |
ockham
deleted the
backbackport/child-theme-php-template-precedence-over-parent-theme-block-template
branch
noisysocks
removed
the
Backport to WP 6.7 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Dec 13, 2021
…mplates over parent theme block templates with equal specificity (#37074) Back-backport of WordPress/wordpress-develop#1985. See there for more background and details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Back-backport of WordPress/wordpress-develop#1985. See there for more background and details.
Merge only once WordPress/wordpress-develop#1985 has been approved and committed!
How has this been tested?
Ideally, have a parent theme with a block template of a certain specificity (e.g.
page-home.html), and a child theme with a PHP template for the same specificity (e.g.page-home.php). Then, verify that Gutenberg gives precedence to the PHP theme (e.g. when rendering a page that matches that specificity).Types of changes
Bug fix.