Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoids polluting Layout functionality with Query Pagination specific requirements. #37113

Conversation

matiasbenedetto
Copy link
Contributor

Description

This characteristic was introduced here by this recently merged PR #36681 and currently it is only necesary for the Query Pagination.

As @ntsekouras suggested we would need to avoid adding extra logic to the Layout block support. So I made this litte refactor to move the functionality to the block's code.

How has this been tested?

Wordpress 5.8.2
Gutenberg latest trunk version

Screenshots

Types of changes

This is just a refactor and no functionality is changed.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • [] I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

…requirements.

This characteristic was introduced here: WordPress#36681 and currently it is only necesary for the Query Pagination block so we can move the functionality to the block's code to avoid adding extra logic to the Layout block support.
@jasmussen
Copy link
Contributor

Thanks for all the effort. Is there any way we can avoid introducing a new classname and naming scheme? In general I feel like we should avoid the wp- prefix, and in this case we have an exiting naming scheme for justifications like these, items-justified-. What do you think?

@ntsekouras
Copy link
Contributor

I'm closing this as the initial changes were eventually reverted. Thanks for your work here @matiasbenedetto!

@ntsekouras ntsekouras closed this Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants